search

matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
171 stars 91 forks source link

Mention notifying AS for sender_localpart events #1810

Closed Kladki closed 2 months ago

Kladki commented 2 months ago

Conduit and Synapse already do this, and appservices such as Draupnir depend on this behavior.

Preview: https://pr1810--matrix-spec-previews.netlify.app

Kladki commented 2 months ago

Actually yours makes more sense if we are keeping my original change in, so let's go with that. I'll update the PR when I get home. 👍

30 Apr 2024 19:09:46 Richard van der Hoff @.***>:

@.**** commented on this pull request.

In data/api/application-service/definitions/registration.yaml[https://github.com/matrix-org/matrix-spec/pull/1810#discussion_r1585290873]:

  • description: |-
  • The localpart of the user associated with the application service. Events will be sent to the AS if this user is the target of the event, or
  • is a joined member of the room where the event occurred.

Ok so if I understand correctly you want to do your change in addition to the one that is already in this pull request, right?

Yes, right.

If so do you think it would be better to switch out your suggestion with my first reply[https://github.com/matrix-org/matrix-spec/pull/1810#discussion_r1585218528], while still keeping my initial change (contents of this PR)?

Oh right. Er well, not really? But I don't feel that strongly about it. It would probably be easier if you just made a change and we can see how it looks, before discussing further.

— Reply to this email directly, view it on GitHub[https://github.com/matrix-org/matrix-spec/pull/1810#discussion_r1585290873], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BFX23U35BTCAFSZ7DVI2YETY77M6TAVCNFSM6AAAAABG3LJIWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSGE2TONZTGA]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/BFX23U35ZAUBUZKRC23YXCLY77M6TA5CNFSM6AAAAABG3LJIWCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTZEBCCE.gif] Message ID: @.***>

richvdh commented 2 months ago

On the subject of the change itself, @turt2live said:

that feels like something that's already in the spec, but not in the OpenAPI seemingly not though - it's definitely intended behaviour though

So I think we're agreed this doesn't need an MSC