search

matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
188 stars 94 forks source link

Clarify that redaction events are subject to auth rules #1824

Closed Kladki closed 4 months ago

Kladki commented 4 months ago

Context: there was a misunderstanding about how redactions interact with auth rules.

Signed-off-by: Matthias Ahouansou matthias@ahouansou.cz

Preview: https://pr1824--matrix-spec-previews.netlify.app

richvdh commented 4 months ago

Context: there was a misunderstanding about how redactions interact with auth rules.

It might be helpful to summarise what the misunderstanding was, for future reference. The discussion in the room is rather verbose.

richvdh commented 4 months ago

... though having read the diff I think I can guess what the misunderstanding was.

Kladki commented 4 months ago

The misunderstanding was that 'are not explicitly part of the auth rules' and 'should always fall into "10. Otherwise, allow".' was interpreted as meaning that redaction events are not subject to the auth rules at all.

richvdh commented 4 months ago

For reference, the affected part of the spec is https://spec.matrix.org/v1.10/rooms/v3/#authorization-rules, and similar in subsequent room versions.

richvdh commented 4 months ago

Can you add the sign-off to the PR description, please? Otherwise we don't have sign-off for your first commit

Kladki commented 4 months ago

Just to ensure you are aware, I have signed off the pull request now.