Wrong implementation version in appservice ping endpoint

[debdutdeb]

Link to problem area: https://github.com/debdutdeb/matrix-spec/blob/a17550648cc4d96bf79ed21103fe30503e1a0fae/content/application-service-api.md?plain=1#L210-L212

Issue

Spec says endpoint was added in 1.7, in reality even the unstable proposal implementation was in 1.10 - unstable, later stable

Expected behaviour

• mention the correct implementation version for the endpoint correctly in spec
• or backport change to 1.7

I feel like #1 is more realistic and easier. As it hasn't been fixed, I think it's safe to assume nobody tried it on 1.7 yet, and simultaneously been so upset or blocked to the version that demanded a backport.

[tulir]

It sounds like you may have been confused by versioning of the spec? The spec does not concern itself with implementation versions, "added in v1.7" means it was added in v1.7 of the spec, hence being in the spec v1.7 changelog. You can see it being a part of the v1.7 spec here: https://spec.matrix.org/v1.7/application-service-api/#pinging (while in v1.6 it's not present: https://spec.matrix.org/v1.6/application-service-api/#pinging)

The feature was added in v1.80.0 of Synapse (and stabilized in v1.84.0), but that's not relevant for the spec.

[debdutdeb]

Ohhhhhh, that makes me ..feel stupid 🙈 I thought that while opening this, but checking the repo couldn't find a reference or line to clear this confusion. Is there any place it's made clear, if you don't mind me asking. By brain defaulted to implementation version as the versions are so close

The feature was added in v1.80.0 of Synapse (and stabilized in v1.84.0), but that's not relevant for the spec.

Thanks also for clarifying this, double checking I did not follow the release history, and just checked the latest tag for the commit.

[clokep]

Sounds like this is all set -- closing.