matrix-org / matrix-spec

The Matrix protocol specification

Apache License 2.0

171 stars 91 forks source link

Fix link to push rule condition kinds. #1841

Closed clokep closed 3 weeks ago

clokep commented 4 weeks ago

As reported by https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$6qi3oaPnzhcBphCN57WC3PDsP9Y5juch2QJGp2ceMgQ?via=matrix.org&via=envs.net&via=element.io.

Signed-off-by: Patrick Cloke clokep@patrick.cloke.us

clokep commented 4 weeks ago

I'm not sure why it thinks the link is broken? It also doesn't seem to have generated a preview. 😢

zecakeh commented 3 weeks ago

The IDs of the page are deduplicated in the browser by manipulating the DOM with JavaScript, and adding a number to the ID. If the test doesn't do the same thing, it will probably not know the real IDs for the links.

zecakeh commented 3 weeks ago

It looks like the easiest solution here is to use the IgnoreURLs option of htmltest.

A better solution would probably be to do the deduplication (and generating the ToC) at rendering time with Hugo, somehow.

zecakeh commented 3 weeks ago

1851 should fix the issue with the CI.