search

matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
197 stars 97 forks source link

#1383 issue : Update edu.yaml #1921

Closed AllMightLegend closed 3 months ago

AllMightLegend commented 3 months ago

Pull Request Checklist

"m.presence" is changed to "m.typing" as here edu has no reason for presence.

Preview: https://pr1921--matrix-spec-previews.netlify.app

turt2live commented 3 months ago

Thanks for the PR! It appears as though some generated output is included, and the checklist has been marked complete without the changes being visible to us. Please review the links on the checklist for more details on what we're expecting.

A descriptive title and link to the issue you're fixing in the PR description would also be appreciated.

AllMightLegend commented 3 months ago

Okay will definitely work on it.But sir can you give me a heads up about the failed check newsfragments !!!

AllMightLegend commented 3 months ago

I am very new to open source contribution sir. I would appreciate your help please.

AllMightLegend commented 3 months ago

The thing is I have changed the edu.yaml file but the error is for checking the newsfragments

KitsuneRal commented 3 months ago

@AllMightLegend, welcome to the community.

  1. The README text that you probably have seen at https://github.com/matrix-org/matrix-spec, advises you to read CONTRIBUTING.rst for details on how to contribute. The part about newsfragments is explained there.
  2. As @turt2live said, your contribution includes generated files in .history/ folder that you probably did not intend to contribute. When you commit the changes locally, I strongly recommend to review the difference with the base Git commit and only stage the files that you actually want to include in the pull request. You apparently used VSCode to edit edu.yaml and it added extra files to .history/ folder that our project has nothing to do with. You can remove these files from the pull request by removing them and committing+pushing the removal action.
AllMightLegend commented 3 months ago

Thank you sir let me do it and see.