matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
188 stars 94 forks source link

#1250 issue : Updated registration.yaml #1929

Closed AllMightLegend closed 1 month ago

AllMightLegend commented 1 month ago

To solve the issue of securely managing the as_token and hs_token in the application service registration YAML file, we can introduce the ability to specify file paths for these tokens (as_token_path and hs_token_path) instead of hardcoding the tokens directly in the YAML file.

Pull Request Checklist

KitsuneRal commented 1 month ago

I'm sorry but this is not a good contribution and you don't seem to have read the contribution guidelines I linked to when responding to your previous pull request. You also ticked the boxes in the checklist without actually fulfilling the requirements stated: I don't see your sign-off; the changelog file, even though present, is malformed; and the changes you proposed cannot be considered as "other changes" because they alter the API, which normally means having to go through a proper proposal process (the contributing guidelines link to it). If you continue to disregard the guidelines described in CONTRIBUTING.rst we may close your pull requests without further explanation.

AllMightLegend commented 1 month ago

I'm very sorry but I'm learning what to do right now.Please don't mind it sir.I will definitely work on it.Please give me a few chances

AllMightLegend commented 1 month ago

Can you please advise me on how to go around this issue.

AllMightLegend commented 1 month ago

Also I think I have understood most of the part of the contributions.rst file .But if I ever ask whether an issue will have to undergo the process proposal or not then will it be okay ??