matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
193 stars 95 forks source link

/join/{roomId} mixes query-params and POST request #720

Open richvdh opened 3 years ago

richvdh commented 3 years ago

/_matrix/client/r0/join/{roomIdOrAlias} is a POST request which also specifies that server_name can be passed via query-parameters. This sort of mixing of query-parameters with params passed in the request body is a bit odd.

(It turns out that one reason it was done this way was because synapse naughtily uses the /join request body as the content of the join event: https://github.com/matrix-org/synapse/issues/8763)

richvdh commented 1 year ago

related: #179