Allow to read bind_password from a file

matrix-org / matrix-synapse-ldap3

An LDAP3 auth provider for Synapse

Apache License 2.0

128 stars 46 forks source link

Allow to read bind_password from a file #172

Closed Ma27 closed 2 years ago

Ma27 commented 2 years ago

That way you don't have to leak your bind password into your config. Useful for e.g. NixOS where config is stored in a world-readable location.

Ma27 commented 2 years ago

Updated the README accordingly and added a Signed-off-by via git commit --amend --signoff :)

squahtx commented 2 years ago

The linter check in CI seems unhappy. Could you give scripts-dev/lint.sh a run?

Ma27 commented 2 years ago

Applied the diff from CI for now, let's see if that's sufficient. Should be an OK change considering that it's only ' vs " and some indentation stuff.

Ma27 commented 2 years ago

AFAICS the mypy error also occurs on master, so it's not actionable here, correct?

squahtx commented 2 years ago

AFAICS the mypy error also occurs on master, so it's not actionable here, correct?

Yes, seems like it.