matrix-org / matrix-user-verification-service

Service to verify details of a user based on a Open ID token.
Other
22 stars 21 forks source link

Ensure the blacklist is skipped in all scenarios when UVS_DISABLE_IP_BLACKLIST: true #36

Closed benbz closed 1 year ago

benbz commented 1 year ago

22 unconditionally consulted the deny list for well-known lookups. It should also respect UVS_DISABLE_IP_BLACKLIST: true

Additionally the redirection test appeared to be testing exactly the opposite thing to what it said and would always consult the blacklist after the initial redirect.

That said IANAND (I am not a node developer) and haven't got an env run the tests in

benbz commented 1 year ago

Closing as !35 was done instead