matrix-org / matrix.to

A simple stateless privacy-protecting URL redirecting service for Matrix
http://matrix.to
Apache License 2.0
932 stars 199 forks source link

`via` parameters get stripped #235

Closed richvdh closed 2 years ago

richvdh commented 2 years ago

Describe the bug

via parameters are not correctly passed through to applications such as element-web

To Reproduce

  1. Open a matrix.to URI with via params. For example: https://matrix.to/#/!jxlRxnrZCsjpjDubDX:matrix.org/$YAum7w2Juad2_Y5o2OjPgccZSMks8rH034uEQnG6p_w?via=matrix.org&via=envs.net&via=kaplu.mba
  2. Choose to open it with element-web, giving a page like the following: image
  3. Note that the 'Continue' button omits the via params: element://vector/webapp/#/room/!jxlRxnrZCsjpjDubDX:matrix.org/$YAum7w2Juad2_Y5o2OjPgccZSMks8rH034uEQnG6p_w

Clicking on the link works ok if your server is already in the room, but otherwise produces a "no known servers" error.

Expected behavior

via params should be included in the element:// URI, so that we can join rooms not yet present on the local homeserver.

Screenshots

image

Desktop (please complete the following information):

georgedorn commented 2 years ago

Confirming this is still an issue; I ran into it over the last couple of days. It applies in particular to users on instances other than the one hosting the room. The server log shows: [...] SynapseError: 404 - No known servers

Given this is the most obvious way to share a room via the element UI, this is a pretty bad experience for new users.