Abuse report buttons do not work (in an encrypted moderation room?)

matrix-org / mjolnir

A moderation tool for Matrix

Apache License 2.0

327 stars 55 forks source link

Abuse report buttons do not work (in an encrypted moderation room?) #153

Closed heftig closed 3 weeks ago

heftig commented 2 years ago

Describe the bug The buttons on the abuse reports do nothing.

To Reproduce

Report an event.
Click on any of the report's buttons in the management room.

Expected behavior Mjolnir reacts to the click.

Additional context

Mjolnir is set up through Pantalaimon and the management room is encrypted.
I've tried the buttons using Element Web and Element Android.
Element Android tells me Mjolnir's reaction events are encrypted, while my own (from both Web and Android) are unencrypted.

cremesk commented 2 years ago

maybe this is related to the encrypted managment room.

here it works fine. the different is my management room is unencrypted.

screenshot

i use also mjolnir is installed via the "Build it"-Method and works also via pantalaimon.

OS: Debian 11 nodejs v: 14.18.1 yarn v: 1.22.15

Yoric commented 2 years ago

@heftig Can you confirm that you're using Mjölnir 1.2.1? There was a snafu this week and I initially tagged/released an image that didn't contain all the patches.

heftig commented 2 years ago

Yes, sorry. Mjolnir 1.2.1, installed via git.

Yoric commented 2 years ago

One thing that is going to make testing/fixing this complicated is that the test suite doesn't support pantalaimon yet. I'll check how hard it would be to add support.

Yoric commented 2 years ago

In the meantime, @heftig, do you see any errors show up in the logs?

heftig commented 2 years ago

No, I already looked. There's no reaction from Mjolnir, not even logs.

TildeSlashC0re commented 2 years ago

No, I already looked. There's no reaction from Mjolnir, not even logs.

well it DOES receive the m.reaction event but it seems to be ignored when coming from an encrypted management room.

similar setup on my end, except for a docker build via the currently supplied dockerfile in the main-branch. can confirm this behavior as described.

heftig commented 1 year ago

I tried a report-to-moderators via msc3215, which was delivered successfully, but the bot still does not react to using any of the reactions on the report message.

turt2live commented 3 weeks ago

I am presuming this is fixed because it doesn't make sense to be broken. If this is still happening, please open a new issue with fresh details/logs.

Gnuxie commented 3 weeks ago

It's not fixed, reactions don't work with Pantalaimon for some reason and we don't know why.

turt2live commented 3 weeks ago

We're deprecating Pantalaimon with https://github.com/matrix-org/mjolnir/releases/tag/v1.8.0, so quickly becomes a non-issue.