matrix-org / mjolnir

A moderation tool for Matrix
Apache License 2.0
328 stars 55 forks source link

Should the unban syntax be changed or better documented? #384

Open PC-Admin opened 2 years ago

PC-Admin commented 2 years ago

Using mjolnir with the https://github.com/spantaleev/matrix-docker-ansible-deploy playbook.

Mjolnir does not actually complete the unban tasks, here's an example:

Michael
"!mjolnir unban COC @zergling.man:perthchat.org"

Moderation-Bot
"Done updating rooms - no errors"

Check #perth:perthchat.org and the user is still banned though. :(

It anyone has any idea why 'unban' isn't working for me here i'm all ears.

Gnuxie commented 2 years ago

if you use !mjolnir unban COC @zergling.man:perthchat.org true it should unban them from the rooms too.

Gnuxie commented 2 years ago

It only unbans them in the list by default because you could override pre-existing room level bans or a list you are watching could unban a user when really you still want them to be banned. There definitely is a discussion to be had about whether this is still appropriate considering the number of people who seem to get caught out by this.

PC-Admin commented 2 years ago

if you use !mjolnir unban COC @zergling.man:perthchat.org true it should unban them from the rooms too.

Thank you! this worked for me :)

It only unbans them in the list by default because you could override pre-existing room level bans or a list you are watching could unban a user when really you still want them to be banned. There definitely is a discussion to be had about whether this is still appropriate considering the number of people who seem to get caught out by this.

Interesting, I suppose I will keep this issue open then, perhaps something will come of it.