search

matrix-org / mscbot-python

mscbot github bot implementation in python
Apache License 2.0
6 stars 2 forks source link

When a concern is raised during FCP, pause FCP and reset FCP timer #3

Open anoadragon453 opened 4 years ago

anoadragon453 commented 4 years ago

The rust bot used to support this functionality. Came up during https://github.com/matrix-org/matrix-doc/pull/2526#issuecomment-629328201.

anoadragon453 commented 3 years ago

And https://github.com/matrix-org/matrix-doc/pull/1772#issuecomment-831891429.

Do we really want to reset the timer? Surely we should only do so on a fcp cancel.

ShadowJonathan commented 3 years ago

I'm 👍 with resetting the timer, it allows for more breathing room, and I think it's not unreasonable to allow that during the last phase of an MSC, they are not to be rushed.

anoadragon453 commented 2 years ago

After some internal discussion, the Spec Core Team has advocated for a concern being raised during FCP not affecting the timer, but simply blocking FCP from completing until all concerns are again resolved.

As for resetting the timer, this should be done via another round of @mscbot fcp cancel and @mscbot fcp <disposition>. Doing so would mean a concern so large that there would either be significant changes to the MSC necessary, or there was a decision to block the MSC for some reason. In either case, cancelling FCP (and collecting a fresh set checkmarks) is a good idea.

richvdh commented 2 years ago

to add to this:

https://github.com/matrix-org/matrix-spec-proposals/pull/3440#issuecomment-1059384303 is an example of a question that I think can be quite safely resolved one way or the other during the FCP. (The two options are: we decide it's fine as-is, or we do a straightforward swap of hide_reply: false to show_reply: true. Neither would require a reset of the FCP IMHO.)

Given that, the only reason for the concern is to make sure we resolve the answer one way or the other. Hence it makes sense that the behaviour be: the timer continues to run, and FCP concludes once either 5 days have elapsed or the concern is resolved, whichever is later.

As @anoadragon453 says, if a larger concern arises, or we decide to make bigger changes, which justify resetting the timer, we do that with @mscbot fcp cancel.