matrix-org / olm

An implementation of the Double Ratchet cryptographic ratchet in C++/C
https://gitlab.matrix.org/matrix-org/olm
63 stars 9 forks source link

make target doc fails (sources expected to be ReST but are mostly Markdown) #75

Closed jonassmedegaard closed 2 years ago

jonassmedegaard commented 2 years ago

This (in source) fails:

make doc

The Cmake build system apparently do not handle documentation at all.

This was fixed in Debian like this:

--- a/Makefile
+++ b/Makefile
@@ -401,6 +401,9 @@
 %.html: %.rst
    rst2html $< $@

+%.html: %.md
+   markdown-it $< > $@
+
 ### dependencies

 -include $(RELEASE_OBJECTS:.o=.d)
uhoreg commented 2 years ago

Does markdown-it produce reasonable results for the math in the docs?

jonassmedegaard commented 2 years ago

Quoting Hubert Chathi (2022-01-13 17:26:30)

Does markdown-it produce reasonable results for the math in the docs?

Ahh, so that is what the comment "when rendering properly" hinted at.

Patch now updated to instead use pandoc with a filter, which works.
Thanks for pointing that out!

(does not work in Debian yet, though: fixing this revealed bugs in both pandoc on locating system-shared katex, and in libjs-katex providing compacted JavaScript - the former is fixed in Debian unstable since a few hours, the latter I will work on tomorrow).

--

uhoreg commented 2 years ago

Thanks. Fixed in https://gitlab.matrix.org/matrix-org/olm/-/commit/dd1905454b033fcc1fe5e4b39dbcdac9ce82c68b