matrix-org / rageshake

Bug report server
Apache License 2.0
30 stars 12 forks source link

Block applications not listed in an allow list. #67

Closed michaelkaye closed 1 year ago

michaelkaye commented 1 year ago

Optionally admins can now set a list of application names that will be accepted by this server.

This is in reaction to admins spending time triaging bug reports for applications they don't own / can't do anything with.

The behaviour will stay as before (all applications permitted) if the option is unset or an empty list; but will log a new warning on startup to say this behaviour is occuring.

If the report is blocked, the error message will include a link to the docs/blocked_rageshake.md file which contains some pointers on why and what to do afterwards; This isn't strictly neccessary but should ease peoples' debugging flows from that point.

michaelkaye commented 1 year ago

I justify my shuffling to avoid the complexity as "the method should return a fully featured config or an error", rather than having the config edited further outside of the method.

I know the commit says "temporary" on the scripts/lint.sh but I think i'd like to leave it in, as it's quite hard to diagnose what a message like 14 main.go main means without the context of it being from the cyclomatic complexity checker.

michaelkaye commented 1 year ago

Apologies for all the to and fro with this; your feedback is appreciated :)