search

matrix-org / rust-synapse-compress-state

A tool to compress some state in a Synapse instance's database
https://pypi.org/project/synapse-auto-compressor/
Apache License 2.0
142 stars 32 forks source link

make jemalloc dependency really optional #101

Closed landryb closed 1 year ago

landryb commented 2 years ago

this allows me to build & run on OpenBSD (cargo build --no-default-features), where jemalloc doesnt build as is (build failure on some linux-only cpuset structs iirc) and the default system allocator performance is sufficient.

it compressed some states but didnt shrink that much my 3gb/15m records states database, i had to drop some room history.

diff from @semarie, pushing it on his behalf.

erikjohnston commented 2 years ago

Looks like clippy is broken, but fixed by #100

erikjohnston commented 1 year ago

I'm afraid I'm going to have to ask you to sign off on our DCO (as per the Synapse contributing guide). Looks like we haven't added a contributing guide to this project yet annoyingly, but I'll do that now.

landryb commented 1 year ago

not my diff, but @semarie - so his decision . If the contribution was mine, i'd put it in the public domain so that anyone could merge it.

semarie commented 1 year ago

@landryb I am fine with Signed-off and Apache 2.0 (or Public domain), even if I am unsure that Cargo.toml modification is subject to licensing.

erikjohnston commented 1 year ago

Thank you both! :heart:

@landryb I am fine with Signed-off and Apache 2.0 (or Public domain), even if I am unsure that Cargo.toml modification is subject to licensing.

Yeah, in this case it probably doesn't matter, but its just much much easier for us if we blanket require it on all PRs unless there is a good reason not to.