search

matrix-org / rust-synapse-compress-state

A tool to compress some state in a Synapse instance's database
https://pypi.org/project/synapse-auto-compressor/
Apache License 2.0
143 stars 33 forks source link

lib: New argument -N to suppress verification #26

Closed heftig closed 2 years ago

heftig commented 3 years ago

I trust its output now, which saves some time.

heftig commented 2 years ago

How would you test that?

anoadragon453 commented 2 years ago

How would you test that?

Good question! However, I might need to direct it to @erikjohnston.

I'm not sure if we currently have a way of testing that checks on the resulting SQL are being performed? If we did have that, then we could presumably check that they weren't being performed when verify is False.

erikjohnston commented 2 years ago

How would you test that?

Good question! However, I might need to direct it to @erikjohnston.

I'm not sure if we currently have a way of testing that checks on the resulting SQL are being performed? If we did have that, then we could presumably check that they weren't being performed when verify is False.

I don't think there is a particularly easy way of doing it. Given the option is off by default, so the verification code gets hit during the tests, I'm kinda OK with this not having tests.