`mypy --strict` for `sydent.http.servlets`

DMRobertson commented 3 years ago

A few minor driveby fixes here:

d277b22d2af04494c87028adcc49c8e0d71a8c44 correct the type hint to Optional[str]
35669ba758c37e3eba996d520bdc1a01dce0db52 for #447
cf342693bd6418dc4ec1e8ad994da0c3e7be2c34 for #445
~~b955b0c28de1572102332441617d9ed49b4c9985 ensure that we always get a str from ip_from_request. I think before this could return a bytes, which could end up in the bowels of sendEmail.~~
- This was wrong. getRawHeaders(str) returns str, and getRawHeaders(bytes) returns bytes. Fixed in 0282973e587c9d1475e3fe7dc2e86bcf874ba68e
6feba5a597dfd8ac1aed6148c13fc94391d885e9 for #449.

The rest is appeasing mypy.

DMRobertson commented 3 years ago

I'll add changelog entries for the bugs I mentioned above too.

DMRobertson commented 3 years ago

I'm going to be cavalier and assume the changelogs are fine. We'll end up with a pair of eyes on them when we do the next release anyway.

matrix-org / sydent