search

matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 84 forks source link

Uncaught `EmailAddressException`s #451

Closed DMRobertson closed 3 years ago

DMRobertson commented 3 years ago

https://sentry.matrix.org/sentry/sydent/issues/196870/

sendEmail might raise EmailAddressException or EmailSendError. The former is almost certainly indicative of a bad request. We should return HTTP 400 if so. I suspect that we instead return 500 internal server error.

https://sentry.matrix.org/sentry/sydent/issues/196870/

DMRobertson commented 3 years ago

Note that this is raised if we fail to parse the from address in Sydent config. I'll ensure that raises a different exception so that we end up returning 500 for that one.