matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 84 forks source link

Catch failures to decode JSON in /register #463

Closed DMRobertson closed 3 years ago

DMRobertson commented 3 years ago

Like #456, but for another error case.

If the remote homeserver fails to give us sensible response, that's not a problem in our application. We can continue to serve everyone else. We should tell the requester what happened and log a warning, but not an error to Sentry.

Most of the examples I saw in Sentry were 404 responses serving up a generic "page not found" body.