Don't store servlets on the `Sydent` object

DMRobertson commented 2 years ago

@clokep writes:

If you're feeling like refactoring a bunch... We should probably just instantiate the servlets in sydent/httpserver.py instead of in sydent/sydent.py. I see no reason for them to be stored on the sydent object.

I concur. Writing this down as a task for the future. Eyeballing it, I'd suggest:

move Servlets class into httpserver.py
store servlets attribute on ClientApiHttpServer instead of Sydent
looks like we'll need to pull out the replicationPush servelet because that's only used on ReplicationHttpsServer
Tests will need updating because they refer to servlets.

Personally, I think the various http servers should NOT keep a reference to the Sydent object around; the Sydent object should pass what's needed to them at construction time (or maybe setup() time).

richvdh commented 1 year ago

I think this happened in #541 ?

clokep commented 1 year ago

It did! 🎉 I didn't realize we had an issue filed.

matrix-org / sydent

Don't store servlets on the `Sydent` object #465