matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 84 forks source link

Pull in type hints for pynacl #478

Closed DMRobertson closed 2 years ago

DMRobertson commented 2 years ago

In my spare time (i.e. not paid Element time) I've been working to add type annotations to pynacl, see pyca/pynacl#660. This is almost done, and the maintainer is keen to include them in a new minor release, "in the next few days/weeks".

Once there's a release, we should remove pynacl from the list of imports we ignore in Sydent's mypy config. Then we should fixup any complaints. The same also holds true for signedjson and synapse.

From a quick glance, there seem to be two complaints:

H-Shay commented 2 years ago

Looks like pynacl 1.5.0 is out, so we can go ahead with this.

DMRobertson commented 2 years ago

Many thanks to Olivier for doing this in #484.