search

matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 83 forks source link

Publish updated Docker image #483

Closed trickert76 closed 2 years ago

trickert76 commented 2 years ago

I was looking for an official docker image of sydent and found the sydent-build. But I was confused about the latest push. Already 10 months old. The last release of Sydent was in November (2.5.1).

I don't understand the description at https://hub.docker.com/r/matrixdotorg/sydent-build - it is talking about installing some packages (which isn't necessary). I needed some time to scroll down and find the docker chapter. But it is also talking about building the image.

Also naming it ..-build is strange for a ready to use image.

I think this is confusing. I've looked into the issue #290 saying - merged - but at the end - it isn't updating the image 10 months ago.

I'd like to have an up2date docker image published, that is automatically updates either on commits to main branch or maybe via a scheduler to also include fixes of other layers (like bullseye/buster libs).

I'm not sure, if this is something, you want (please give me a hint). But at the end it is very easy to be implemented via Github Actions, so nobody needs to do something. See documentation - https://github.com/marketplace/actions/build-and-push-docker-images - I've already running examples. If you want, I can build a PR at least for a "latest" tag (ignoring specific tags).

callahad commented 2 years ago

We automatically publish Docker images for Synapse, and could re-use that workflow here.

The sydent-build image is not meant for external use, nor is it meant to be persisted... looks like it was accidentally pushed to Docker Hub. We'll take it down and consider replacing it with a proper image in the near future.

DMRobertson commented 2 years ago

With #492 and #493 we should now be publishing images here. The main branch is published continuously with tag latest. Tagged release versions should also be published, but there aren't any examples of those yet.