search

matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 84 forks source link

`prometheus_client` and `sentry_sdk` are not listed as dependencies #500

Closed DMRobertson closed 2 years ago

DMRobertson commented 2 years ago

They're optional. But we use them on matrix.org/vector.im. We should mark these as extras.

clokep commented 2 years ago

Both of those are listed in python_dependencies.py, sentry_sdk is listed under a sentry extra.

prometheus_client is always installed, which might be excessive?

I'm unsure what change this is suggesting to make.

DMRobertson commented 2 years ago

This is for Sydent---not synapse.

DMRobertson commented 2 years ago

(Pull request to follow shortly)

clokep commented 2 years ago

This is for Sydent---not synapse.

Ah 🤦 , that explains it! 👍 Ignore me!