Run tests even if newsfile step fails

matrix-org / sydent

Sydent: Reference Matrix Identity Server

http://matrix.org

Apache License 2.0

303 stars 84 forks source link

Run tests even if newsfile step fails #507

Closed DMRobertson closed 2 years ago

DMRobertson commented 2 years ago

At present, if the newsfile step is skipped, then tests are also skipped. This happened on the main branch here: https://github.com/matrix-org/sydent/runs/5306840738?check_suite_focus=true

erikjohnston commented 2 years ago

FWIW Synapse repo does something like this, while also not running the tests if the newsfile lint fails. Not entirely sure how, but its mentioned at https://github.com/matrix-org/synapse/blob/develop/.github/workflows/tests.yml#L51-L57

DMRobertson commented 2 years ago

Looks like there's a distinction between a step failing and a step being skipped. It's the newsfile check being skipped on main that I want to capture here. Will take Erik's advice and crib from Synapse.

clokep commented 2 years ago

I wonder if we can move those checks into the meta repo and re-use them? Not sure if that's possible though.