parsing of ip_whitelist

[1848]

idk if this is a bug but it is at least bad design in my opinion..

I see there is a "hidden" ip_blacklist which is active by default.

When I add an ipaddr to ip_whitelist it gets ignored because it wont get parsed when its in the DEFAULT section. It only works when its in the GENERAL section.

I spend some time to figure this out. I think ip_whitelist should

• get parsed when it is set under DEFAULT and if there is not another ip_whitelist under GENERAL or
• should not be generated on first startup in the DEFAULT section.

Additionally I think it would be a good idea to put default blacklisted IPs in ip_blacklist instead of keeping them "hidden" in the code.

[richvdh]

seems to be https://github.com/matrix-org/sydent/issues/101.

[1848]

Yes I agree, documentation could be better, but I think the bigger issue here is that the key wont get parsed as expected. And that the blacklist which is defined in the code should be defined in the config file.

[richvdh]

101 is a general issue which goes beyond documentation; it generally concerns the fact that the config file doesn't work as anyone expects it to.