matrix-org / sydent

Sydent: Reference Matrix Identity Server
http://matrix.org
Apache License 2.0
303 stars 84 forks source link

Allow turning off of terms for Sydent restricted to one homeserver #569

Closed hanthor closed 1 year ago

hanthor commented 1 year ago

With #565 Sydent is considered first-party. Terms should either be turned off or auto-accepted for all users if a toggle is set

H-Shay commented 1 year ago

I think this could be achieved by setting the terms.path in the config to ""? Looks like that results in terms.getMasterVersion() returning None, which should short-circuit the terms check in the auth code:

https://github.com/matrix-org/sydent/blob/b5844442831d0953d99a937dc08bf1dab1718e41/sydent/http/auth.py#L79-L87

hanthor commented 1 year ago

Yes this might be a client implementation issue. With no policy set it still prompts to trust the identity server

markup_image (1).png

H-Shay commented 1 year ago

Right - let us know if there's anything we can do in Sydent then to help - otherwise if it's a client implementation issue it's out of our hands?