richvdh
commented
1 year ago looks like the invite event might have an invalid key_validity_url ? can you "View source" on the invite event?
Closed daedric7 closed 12 months ago
richvdh
commented
1 year ago looks like the invite event might have an invalid key_validity_url ? can you "View source" on the invite event?
daedric7
commented
1 year ago looks like the invite event might have an invalid
key_validity_url? can you "View source" on the invite event?
You might be correct:
{
"content": {
"display_name": "tes...@agu...",
"key_validity_url": "https://aguiarvieira.pt/_matrix/identity/v2/pubkey/isvalid",
"public_key": "H5TlGldhvLE1bU6ZtrCLuhOxB4zRhZStj65K/p7P2tg",
"public_keys": [
{
"key_validity_url": "/_matrix/identity/api/v1/pubkey/isvalid",
"public_key": "H5TlGldhvLE1bU6ZtrCLuhOxB4zRhZStj65K/p7P2tg"
},
{
"key_validity_url": "/_matrix/identity/api/v1/pubkey/ephemeral/isvalid",
"public_key": "fK46giIll7mMcBDZ9uC-Chy3USS3_YXiT1cfD42Og8I"
}
]
},
"origin_server_ts": 1696111714136,
"room_id": "!tnOYhXKUIldKCOOyzb:aguiarvieira.pt",
"sender": "@daedric:aguiarvieira.pt",
"state_key": "wHvIjathcHQKsuRLpWKAyaYQUaKROdYKDlyUknKEDBsctLLWZMqnRUHDmxUyMJCMeukCMKsmmaxSuNjtUBlwwuENCuiFQTDfEsOlkUybgwCAuYwRZpVhVtrMzcuNgxjc",
"type": "m.room.third_party_invite",
"unsigned": {
"age": 133243859
},
"event_id": "$FXcbZ57l0rFIWDfH9vZt36l5ib9NaZcodbU7HnbyP_8",
"user_id": "@daedric:aguiarvieira.pt",
"age": 133243859
}Indeed, that is invalid. key_validity_url should be populated by sydent, in the response to /_matrix/identity/v2/store-invite. Might be worth checking http.client_http_base in your sydent config.
daedric7
commented
1 year ago Indeed, that is invalid.
key_validity_urlshould be populated by sydent, in the response to/_matrix/identity/v2/store-invite. Might be worth checkinghttp.client_http_basein your sydent config.
It's set:
client_http_base = https://aguiarvieira.pt
Both in [DEFAULT] and [general]
richvdh
commented
1 year ago right, but it needs to be in an [http] section; see for example https://github.com/matrix-org/sydent/blob/2267ee2e3ab3bdfe386c4d98d9490c074e4a7c9c/matrix_is_test/launcher.py#L22-L27
(Don't get me started about the lack of documentation)
daedric7
commented
1 year ago right, but it needs to be in an
[http]section; see for example(Don't get me started about the lack of documentation)
It's alright, i understand that the documentation is... sparse and out of date. As it has been said before:
Sydent hasn't received much love
I'll do a quick test and report back.
daedric7
commented
1 year ago Aaannnd... Problem solved.
Although i still got the random error after signig up and accepting (non existant) terms, the join sucedded.
For reference, the difference in the invite's source:
{
"content": {
"display_name": "tes...@aguiarviei...",
"key_validity_url": "https://aguiarvieira.pt/_matrix/identity/v2/pubkey/isvalid",
"public_key": "H5TlGldhvLE1bU6ZtrCLuhOxB4zRhZStj65K/p7P2tg",
"public_keys": [
{
"key_validity_url": "https://aguiarvieira.pt/_matrix/identity/api/v1/pubkey/isvalid",
"public_key": "H5TlGldhvLE1bU6ZtrCLuhOxB4zRhZStj65K/p7P2tg"
},
{
"key_validity_url": "https://aguiarvieira.pt/_matrix/identity/api/v1/pubkey/ephemeral/isvalid",
"public_key": "N72jNH9jYyDJ3_5FXYFqEZUtQiJj-4l9L1CqMFnQ9Do"
}
]
},
"origin_server_ts": 1696250537363,
"sender": "@daedric:aguiarvieira.pt",
"state_key": "NZqkbanXMTyDLLJJacuuPZOQkQjssbFOuuNaswsXKTydAPztyVkHxcAHtgdSkYGpJVlFXkOhgxLwKQQEqsazOIstuvwLsdtkiJzMMgepKUkKKuMHyEiCBKAhSzxEptFg",
"type": "m.room.third_party_invite",
"unsigned": {
"age": 106
},
"event_id": "$HSBqLGFR6Ll45g8ssEw0Mlhxm19Uvcwor0sZ6cj6-ug",
"room_id": "!tnOYhXKUIldKCOOyzb:aguiarvieira.pt"
}
reivilibre
commented
12 months ago thanks for reporting back. I guess this is basically an instance of poor documentation biting people :(
It has been detected that the final steps of inviting someone from outside Matrix to a room, via email, ends in the issue error.
Details:
Selfhosted Synapse, Element and Sydent.
Versions:
Sydent: Unknown, git cloned and built into a docker container recently.
{"versions": ["r0.1.0", "r0.2.0", "r0.2.1", "r0.3.0", "v1.1", "v1.2", "v1.3", "v1.4", "v1.5"]}Synapse:
Synapse 1.93.0rc1Element:
Process:
Link:
https://aguiarvieira.pt/#/room/%21tnOYhXKUIldKCOOyzb%3Aaguiarvieira.pt?via=aguiarvieira.pt&email=test06%40aguiarvieira.pt&signurl=https%3A%2F%2Faguiarvieira.pt%2F_matrix%2Fidentity%2Fapi%2Fv1%2Fsign-ed25519%3Ftoken%3DwHvIjathcHQKsuRLpWKAyaYQUaKROdYKDlyUknKEDBsctLLWZMqnRUHDmxUyMJCMeukCMKsmmaxSuNjtUBlwwuENCuiFQTDfEsOlkUybgwCAuYwRZpVhVtrMzcuNgxjc%26private_key%3Dr_mudF73hVkAs5ucDoEBH39ArOulhd1U2GMSX2OnKhI&room_name=Wallpapers&room_avatar_url=mxc%3A//aguiarvieira.pt/b2c0a20111de0dcd2b9a8cfb648889604c1433f01703102296830771200&inviter_name=Ricardo&guest_access_token=&guest_user_id=&room_type=Link:
https://aguiarvieira.pt/_matrix/client/unstable/registration/email/submit_token?token=zJALrZdsupCCmWlHSMORFWqthtLUMDqp&client_secret=cR7qO6TxLL9Q6hdiQF3rB47bTruEprOF&sid=wiiphWcNVCCOJfqjSynapse logs that i could find (there are 20 workers... there may be more but i found nothing relevant):
Sydent logs:
Video of the signing in:
https://github.com/matrix-org/sydent/assets/4562461/dbc0d463-348c-4518-b402-0d819298ae92
Request payload:
{"third_party_signed":{"mxid":"@test06:aguiarvieira.pt","sender":"@daedric:aguiarvieira.pt","token":"wHvIjathcHQKsuRLpWKAyaYQUaKROdYKDlyUknKEDBsctLLWZMqnRUHDmxUyMJCMeukCMKsmmaxSuNjtUBlwwuENCuiFQTDfEsOlkUybgwCAuYwRZpVhVtrMzcuNgxjc","signatures":{"aguiarvieira.pt":{"ed25519:0":"tbFw8CPq20pa/2kK8zh2nnG+zkU03ZcdfoG9MRsKSQzTnZoQ5UlaMIVur940PRZwqY1EyE4OU0JbgJTfzYexDA"}}}}Relevant request:
https://aguiarvieira.pt/_matrix/client/v3/join/!tnOYhXKUIldKCOOyzb%3Aaguiarvieira.pt