search

matrix-org / sygnal

Sygnal: reference Push Gateway for Matrix
Apache License 2.0
166 stars 148 forks source link

set time-to-live for webpush messages #185

Closed bwindels closed 3 years ago

bwindels commented 3 years ago

Configurable with a default of 15 minutes.

callahad commented 3 years ago

Do we need to document the ttl configuration anywhere? (The VAPID config isn't documented either, so I guess we can let this slip, too, while WebPush is experimental)

Does ttl need to be added to the UNDERSTOOD_CONFIG_FIELDS list?

bwindels commented 3 years ago

Thanks for the review @callahad, ready for another look.

callahad commented 3 years ago

r+ once CI passes and if you promise that you've tested this locally and it at least appears to work.

bwindels commented 3 years ago

@callahad Have tested again, all seems to work :+1: