search

matrix-org / sygnal

Sygnal: reference Push Gateway for Matrix
Apache License 2.0
165 stars 147 forks source link

Fix overly generous matching of pushkin app IDs, introduced in 0.5.0 #269

Closed squahtx closed 2 years ago

squahtx commented 2 years ago

Addresses #255 together with #268 #281 and #270.

Prevent dots (.) from being interpreted as wildcards. Only use pushkins which match the entire app ID, rather than a substring.

squahtx commented 2 years ago

Mypy's sad, otherwise looks good.

It'll be because it needs #268 to be merged first.

squahtx commented 2 years ago

Nothing's really changed since the last review. It's only a merge from main followed by a switch to matrix-python-common.