search

matrix-org / sygnal

Sygnal: reference Push Gateway for Matrix
Apache License 2.0
165 stars 147 forks source link

Add type hints to `sygnal/http.py` #273

Closed H-Shay closed 2 years ago

H-Shay commented 2 years ago

As the title states. Also want to acknowledge that I used DMRobertson's type stub work in Sydent in this PR, specifically stubs/twisted/web/http.pyi.

DMRobertson commented 2 years ago

I wonder if there's a way to share stubs between repos?

Git submodules would be my suggestion, assuming we don't want to publish a stubs package to pypi

reivilibre commented 2 years ago

the answer there might be to upstream the type annotations and get rid of the stubs altogether :sweat_smile: