matrix-org / sygnal

Sygnal: reference Push Gateway for Matrix
Apache License 2.0
155 stars 140 forks source link

Don't use aioapns 2.1 #294

Closed DMRobertson closed 2 years ago

DMRobertson commented 2 years ago

Fixes #293.

aioapns 2.1 made a breaking change: one can no longer pass an event loop directly to APNs.init. We could change our code to fix it, but (regrettably) I think it's quicker to avoid using that version. See also https://github.com/matrix-org/sygnal/issues/293#issuecomment-1023453460

I wonder if unit tests would have spotted this? Presumably not.

DMRobertson commented 2 years ago

Oh bugger, newsfile.