While we now successfully catch when clients set this value incorrectly, raising an error means that this we get notified via Sentry when it happens - and as this data is user-supplied, we can't really do much about it, making the error noise.
This issue proposes to downgrade the log from an error to a warning. Such instances will then still be logged, but not show up in Sentry/potentially alarm sysadmins.
Describe the bug As of https://github.com/matrix-org/sygnal/pull/292 we now check that
default_payloadis a dictionary before interacting with it.default_payloadis a user-supplied dictionary which is set when a client sets up their pusher viaPOST /_matrix/client/v3/pushers/set.While we now successfully catch when clients set this value incorrectly, raising an error means that this we get notified via Sentry when it happens - and as this data is user-supplied, we can't really do much about it, making the error noise.
This issue proposes to downgrade the log from an error to a warning. Such instances will then still be logged, but not show up in Sentry/potentially alarm sysadmins.