Closed dklimpel closed 11 months ago
I'm pretty sure this broke apns configurations, as we pinned back aioapns to an older version that didn't support Python 3.10 here: https://github.com/matrix-org/sygnal/issues/293
│ Error during startup: │
│ Traceback (most recent call last): │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/sygnal.py", line 228, in start │
│ yield ensureDeferred(self.make_pushkins_then_start()) │
│ File "/usr/local/lib/python3.10/site-packages/twisted/internet/defer.py", line 1374, in ensureDeferred │
│ return Deferred.fromCoroutine(coro) │
│ File "/usr/local/lib/python3.10/site-packages/twisted/internet/defer.py", line 1349, in fromCoroutine │
│ return _cancellableInlineCallbacks(coro) │
│ File "/usr/local/lib/python3.10/site-packages/twisted/internet/defer.py", line 2157, in _cancellableInlineCallbacks │
│ _inlineCallbacks(None, gen, status, _copy_context()) │
│ --- <exception caught here> --- │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/sygnal.py", line 228, in start │
│ yield ensureDeferred(self.make_pushkins_then_start()) │
│ File "/usr/local/lib/python3.10/site-packages/twisted/internet/defer.py", line 1997, in _inlineCallbacks │
│ result = context.run(gen.send, result) │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/sygnal.py", line 200, in make_pushkins_then_start │
│ self.pushkins[app_id] = await self._make_pushkin(app_id, app_cfg) │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/sygnal.py", line 195, in _make_pushkin │
│ return await clarse.create(app_name, self, app_config) │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/notifications.py", line 189, in create │
│ return cls(name, sygnal, config) │
│ File "/usr/local/lib/python3.10/site-packages/sygnal/apnspushkin.py", line 191, in __init__ │
│ self.apns_client = APNs( │
│ builtins.TypeError: APNs.__init__() got an unexpected keyword argument 'loop' │
Do we do something like this other PR in a different project using aioapns to fix it? https://github.com/zulip/zulip/pull/21066/files
Python 3.7 is EOL
Python 3.11 is also the Python version of Synapse in Dockerfile
Max Python version here: 3.10. The upgrade to Python 3.11 seems to need more dependency updates.
Possible solutions / causes:
Related to:
342