I've had this change in my own fork for a long time now and haven't noticed any issue with my Synapse instance, certainly no error logs about the LoggingContext.
This fixes #56 and supersedes #74 (the latter PR changes the LoggingContext instead of just removing it).
In turn, fixing this LoggingContext issue makes it start to log what actually happens when this code is hit, the whole "Consumer ask to stop producing". For that issue I'm not sure what the fix would be though. Is this just about the storage provider trying to provide a file to a client that no longer has a connection? That error line happens regularly in my logs.
As per the comments by @richvdh: https://github.com/matrix-org/synapse-s3-storage-provider/issues/56#issuecomment-1103873051 and https://github.com/matrix-org/synapse-s3-storage-provider/issues/56#issuecomment-1224184350
I've had this change in my own fork for a long time now and haven't noticed any issue with my Synapse instance, certainly no error logs about the LoggingContext.
This fixes #56 and supersedes #74 (the latter PR changes the
LoggingContextinstead of just removing it).In turn, fixing this
LoggingContextissue makes it start to log what actually happens when this code is hit, the whole "Consumer ask to stop producing". For that issue I'm not sure what the fix would be though. Is this just about the storage provider trying to provide a file to a client that no longer has a connection? That error line happens regularly in my logs.