Allow configuration of timeout for s3 storage provider downloads/uploads

matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3

Apache License 2.0

127 stars 34 forks source link

Allow configuration of timeout for s3 storage provider downloads/uploads #31

Closed michaelkaye closed 4 years ago

michaelkaye commented 4 years ago

A task from a previous PR that would be useful to fix 'sometime', but does not block that PR.

https://github.com/matrix-org/synapse-s3-storage-provider/pull/30#discussion_r370255268

richvdh commented 4 years ago

Are you sure this needs to be configurable? I don't think the setting does what you think it does: it's the amount of time the Matrix client gets to start re-reading data after we fill its buffer with data read from S3. In particular it's not a thing that seems like it would need adjusting for large files.

michaelkaye commented 4 years ago

Ah, this does not do what i thought it did. So is probably not worth configuring.