matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3

Apache License 2.0

118 stars 33 forks source link

Add custom URL support #39

Closed HelderFSFerreira closed 4 years ago

HelderFSFerreira commented 4 years ago

Make the URL redirection possible as it isn't configurable.

25

HelderFSFerreira commented 4 years ago

Ok, seems fair, working on it.

Just FYI the way to configure the credentials is using environmental variables and that's why I followed this route. The feature to having the url redirection using the file was implemented so I thought that will be a matter of time to have it implemented using EV ( issue )

richvdh commented 4 years ago

Hi @HelderFSFerreira; are you still interested in working on this?

HelderFSFerreira commented 4 years ago

Hi,

Yup, sorry for the delay. I should get it done by the end of this week. Is it OK for you?

richvdh commented 4 years ago

sure, just checking it hadn't been forgotten!

richvdh commented 4 years ago

Hi @HelderFSFerreira: I'm going to close this for now. If you find time to work on it in the future we'll be glad to reopen it!