Fix upload script to handle media that has never been accessed

matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3

Apache License 2.0

118 stars 33 forks source link

Fix upload script to handle media that has never been accessed #47

Closed erikjohnston closed 3 years ago

erikjohnston commented 3 years ago

This is done by falling back to the created_ts if last_access_ts is null.

Fixes #45.

clokep commented 3 years ago

Also, not sure what's up with the build? Seems like it has been running for several hours.

erikjohnston commented 3 years ago

If my understanding is correct this means that if a file is created 2 months ago and never accessed, when this script is run saying to upload everything over 1 month ago it will now upload it, instead of ignoring it and leaving it on disk forever?

Yup, exactly

clokep commented 3 years ago

I believe #45 is a dup of #38, so I've marked that as being fixed by this as well.