search

matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3
Apache License 2.0
118 stars 33 forks source link

Please push latest changes for synapse v.1.45.0 to PyPi #64

Closed patrickstump closed 2 years ago

patrickstump commented 2 years ago

Describe the bug

The version 1.0 in PyPi does not contain the latest update required to be compatible with synapse v1.45.0. This commit has the necessary changes.

When starting the synapse v1.45.0 server with a working config and the version 1.0 from PyPi, installed via pip, the following error crashes the media worker.

AttributeError: 'HomeServerConfig' object has no attribute 'media_store_path'

To Reproduce Steps to reproduce the behavior:

  1. Install this storage provider from pip pip3 install synapse-s3-storage-provider
  2. Run synapse with a homeserver config using this module.

Expected behavior Start up with existing correct config with no error.

Desktop (please complete the following information): NA

Smartphone (please complete the following information): NA

Additional context NA

babolivier commented 2 years ago

Unfortunately, we don't maintain the PyPI distribution channel for this project, so you'll need to either get in touch with https://pypi.org/user/alexbabel/ (who seems to be maintaining the PyPI distribution of this project) and ask them to update the project on there, or install it via pip + git:

pip install git+https://github.com/matrix-org/synapse-s3-storage-provider.git
patrickstump commented 2 years ago

Thank you for the update and the install procedure.

AlexanderBabel commented 2 years ago

Hey, I currently maintain the PyPi package. I just updated it to the latest version.

BTW, I would be glad if we could add support for automatic pushing through GitHub workflows. Also, I would be happy to transfer to ownership of the package to someone from matrix-org.

DMRobertson commented 2 years ago

Hi @AlexanderBabel, thanks for reaching out to us. We'd like to transfer ownership to a generic matrix.org account on PyPI, as you suggest. I'll contact you directly to discuss!

DMRobertson commented 2 years ago

Thanks @AlexanderBabel for your help. https://pypi.org/project/synapse-s3-storage-provider/ is now owned by https://pypi.org/user/matrixdotorg/. I'll publish an update now.

DMRobertson commented 2 years ago

I'll publish an update now.

Ahh, I missed that you had updated the package a few days ago. I'm working to get an automatic release process setup for this and our other modules.