search

matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3
Apache License 2.0
118 stars 33 forks source link

Fix dependencies syntax #80

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

Fixes #79

Tested by pip install . afterwards.

I have no idea if the upper bounds are necessary or if they'll introduce conflicts with synpapse's lockfile.

clokep commented 1 year ago

Did pip accept these, but poetry won't? Why the change?

Oh I should read the issue, #79 explains it.

DMRobertson commented 1 year ago

Did pip accept these, but poetry won't? Why the change?

See https://github.com/matrix-org/synapse-s3-storage-provider/issues/79#issuecomment-1275940764: pip ignores these. poetry ignored these with a warning, but now seems to error.

Looks reasonable, although CI is quite x .

Yeah. I have no idea what is happening with CI.

DMRobertson commented 1 year ago

tox -e py succeeds on my machine.

For the integration test: I have no idea, but it failed here (develop) in the same way.