Closed xangelix closed 1 year ago
Appears to now be working well--appreciate anyone else who's able to give it a go.
@xangelix Looks like there's some linting and test issues!
See #83 for the integration test.
Thanks for the quick response, linting errors are now fixed.
See #83 for the integration test.
After the changes here, I am unable to reproduce any failing tests unique to my branch. However, I was also unable to reproduce a passing set of tests on main:
https://github.com/xangelix/synapse-s3-storage-provider/actions/runs/3357238074
https://github.com/xangelix/synapse-s3-storage-provider/actions/runs/3357254105
This is my first time dealing with GitHub actions, so I may be overlooking something, but it does not appear to me the failing test on 3.7 has to do with this pull request? I'm not certain how the passing build at https://github.com/matrix-org/synapse-s3-storage-provider/actions/runs/3320569047/jobs/5487117200 (on #40c6a5) was accomplished.
Adds support for SSE-C.
Needs testing, not ready to be merged.