matrix-org / synapse-s3-storage-provider

Synapse storage provider to fetch and store media in Amazon S3
Apache License 2.0
118 stars 33 forks source link

Fix CI again #90

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

CI failed on main because we were trying to setup-python version 3.6, which isn't available on the ubuntu-latest runner. Presumably there's a new version of Ubuntu in use?

Then there was a new complaint:

check_isort: install_deps> python -I -m pip install isort
check_isort: freeze> python -m pip freeze --all
check_isort: isort==5.11.4,pip==22.3.1,setuptools==65.6.3,wheel==0.38.4
check_isort: commands[0]> /bin/sh -c 'isort -c -sp setup.cfg -rc s3_storage_provider.py setup.py scripts/s3_media_upload'
check_isort: failed with /bin/sh (resolves to /bin/sh) is not allowed, use allowlist_externals to allow it
check_isort: FAIL ✖ in 2.26 seconds

Which is hopefully resolved by the second commit.

I dodged a similar problem for find by commenting it out.

IDK why this is popping up now. Do we not pin the version of tox we use, and does a new version disallow external binaries by default?