DMRobertson
commented
3 years ago Thanks for writing this up!
Searching for [ERROR] and [FAIL] in the check log file, tests.rest.client.test_relations seems to have be failing in its setup:
Traceback (most recent call last):
File "/build/matrix-synapse/src/synapse-1.42.0/tests/unittest.py", line 75, in new
return code(orig, *args, **kwargs)
File "/build/matrix-synapse/src/synapse-1.42.0/tests/unittest.py", line 122, in setUp
return orig()
File "/build/matrix-synapse/src/synapse-1.42.0/tests/unittest.py", line 300, in setUp
self.prepare(self.reactor, self.clock, self.hs)
File "/build/matrix-synapse/src/synapse-1.42.0/tests/rest/client/test_relations.py", line 52, in prepare
self.room = self.helper.create_room_as(self.user_id, tok=self.user_token)
File "/build/matrix-synapse/src/synapse-1.42.0/tests/rest/client/utils.py", line 96, in create_room_as
assert channel.result["code"] == b"%d" % expect_code, channel.result
builtins.AssertionError: {'version': b'1.1', 'code': b'500', 'reason': b'Internal Server Error', 'headers': [(b'Server', b'1'), (b'Date', b'Sat, 18 Sep 2021 20:03:33 GMT'), (b'Content-Type', b'application/json'), (b'Cache-Control', b'no-cache, no-store, must-revalidate'), (b'Access-Control-Allow-Origin', b'*'), (b'Access-Control-Allow-Methods', b'GET, HEAD, POST, PUT, DELETE, OPTIONS'), (b'Access-Control-Allow-Headers', b'X-Requested-With, Content-Type, Authorization, Date')], 'body': b'{"errcode":"M_UNKNOWN","error":"Internal server error"}', 'done': True}There's also an internal server error in the two failures too:
[FAIL]
Traceback (most recent call last):
File "/build/matrix-synapse/src/synapse-1.42.0/tests/rest/client/test_third_party_rules.py", line 157, in test_cannot_modify_event
self.assertEqual(channel.code, 200, channel.result)
File "/usr/lib/python3.9/site-packages/twisted/trial/_synctest.py", line 424, in assertEqual
super().assertEqual(first, second, msg)
File "/usr/lib/python3.9/unittest/case.py", line 829, in assertEqual
assertion_func(first, second, msg=msg)
File "/usr/lib/python3.9/unittest/case.py", line 822, in _baseAssertEqual
raise self.failureException(msg)
twisted.trial.unittest.FailTest: 500 != 200 : {'version': b'1.1', 'code': b'500', 'reason': b'Internal Server Error', 'headers': [(b'Server', b'1'), (b'Date', b'Sat, 18 Sep 2021 20:04:48 GMT'), (b'Content-Type', b'application/json'), (b'Cache-Control', b'no-cache, no-store, must-revalidate'), (b'Access-Control-Allow-Origin', b'*'), (b'Access-Control-Allow-Methods', b'GET, HEAD, POST, PUT, DELETE, OPTIONS'), (b'Access-Control-Allow-Headers', b'X-Requested-With, Content-Type, Authorization, Date')], 'body': b'{"errcode":"M_UNKNOWN","error":"Internal server error"}', 'done': True}
tests.rest.client.test_third_party_rules.ThirdPartyRulesTestCase.test_cannot_modify_event
alex19EP
clokep
erikjohnston
Description
hello. I am trying to update synaps to 1.42.0 in Arch Linux some test are failing on 1.42.0 and 1.41.1 version. i think it has something to do with new packages in our repositories. since some time ago version 1.41.1 passed all tests successfully.
synaps dependencies versions
Repository : extra Name : libwebp Version : 1.2.1-2 Description : WebP library and conversion tools Architecture : x86_64 URL : https://developers.google.com/speed/webp/ Licenses : BSD Groups : None Provides : libwebp.so=7-64 libwebpdecoder.so=3-64 libwebpdemux.so=2-64 libwebpmux.so=3-64 Depends On : libpng libjpeg libtiff giflib Optional Deps : freeglut: vwebp viewer Conflicts With : None Replaces : None Download Size : 333.30 KiB Installed Size : 1087.96 KiB Packager : Jan Alexander Steffens (heftig)Steps to reproduce
all tests should pass successfully. I will attach build and check logs if someone who knows the code base and understands the testing system can give a hint - I will be very grateful.
Version information
Version: 1.41.1 and 1.42.0
Install method: distribution package
Platform: Arch Linux
matrix-synapse-1.42.0-1-x86_64-build.log matrix-synapse-1.42.0-1-x86_64-check.log