search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.81k stars 2.13k forks source link

`conf/workers-shared-extra.yaml.j2` is applied to monolith Complement runs #13590

Open MadLittleMods opened 2 years ago

MadLittleMods commented 2 years ago

docker/complement/conf/workers-shared-extra.yaml.j2 seems to apply even when SYNAPSE_COMPLEMENT_USE_WORKERS=true isn't set. I assume they aren't supposed to stack like that for the monolith?

Noticed because I saw the reject_limit as 99999 when investigating https://github.com/matrix-org/synapse/pull/13541#discussion_r952064254. Disabling the rate limit could be as expected for the monolith but the way it's inherited from workers seems weird.

This is the command I was running for reference but it probably works in the simplified case as well,

TEST_ONLY_IGNORE_POETRY_LOCKFILE=1 TEST_ONLY_SKIP_DEP_HASH_VERIFICATION=1 COMPLEMENT_DEBUG=1 COMPLEMENT_KEEP_BLUEPRINTS="fed.perf_many_messages.hs1" COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh -run TestMessagesOverFederation -p 1

Dev notes

Related PRs:

DMRobertson commented 2 years ago

Don't have much familiarity here. @reivilibre might be able to advise?

H-Shay commented 2 years ago

Marking this as occasional as it doesn't occur on all runs, and tolerable as it seems that there is a workaround.

richvdh commented 2 years ago

I assume they aren't supposed to stack like that for the monolith?

No, I think this is expected behaviour. As the first two lines in the file say:

This file extends the default 'shared' configuration file (from the 'synapse-workers' docker image) with Complement-specific tweak.

I think it's just ended up with a bit of a misleading name, so the solution here is just to rename it?