matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.79k stars 2.13k forks source link

Complement flake `TestFederationKeyUploadQuery/Parallel/Can_query_remote_device_keys_using_POST` #16020

Open DMRobertson opened 1 year ago

DMRobertson commented 1 year ago

Seen in #16018, namely https://github.com/matrix-org/synapse/actions/runs/5689189095/job/15420265614

DMRobertson commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/5735750569/job/15544028079#step:5:6235 on develop+latestdeps, #16049

DMRobertson commented 1 year ago
       federation_upload_keys_test.go:112: MatchResponse key 'device_keys.@alice:hs1.HQSZVWDSZW.unsigned.device_display_name' missing - http://127.0.0.1:33361/_matrix/client/v3/keys/query => {"device_keys":{"@alice:hs1":{"HQSZVWDSZW":{"algorithms":["m.olm.v1.curve25519-aes-sha2","m.megolm.v1.aes-sha2"],"device_id":"HQSZVWDSZW","keys":{"curve25519:HQSZVWDSZW":"zHcxVx4cUhILr0RIFQbWm2QptV8cUpmJz6+yzREhEhU","ed25519:HQSZVWDSZW":"uubiIl3Re7WKps6W6S3fYOXSsrp+K9uEEOL4W7EUfSg"},"signatures":{"@alice:hs1":{"ed25519:HQSZVWDSZW":"a8SmLgqYuA9og+lKKQ9xc1W6yAC763s34qYpQMC7novGTNd1gnHj5Wln3q/C7618QuWNidImxaXWCEB7aUhGAA"}},"user_id":"@alice:hs1"}}},"failures":{},"master_keys":{},"self_signing_keys":{},"user_signing_keys":{}}
DMRobertson commented 1 year ago

And https://github.com/matrix-org/synapse/actions/runs/5737293668/job/15548766143

DMRobertson commented 1 year ago

Maybe related to #15975?

clokep commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/5851753987/job/15872401761?pr=16106

clokep commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/5938740638/job/16103891133?pr=16157

I seem to be getting this more frequently recently...

clokep commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/5921915531/job/16055233357?pr=16139

clokep commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/5979001067/job/16222343343?pr=16099

DMRobertson commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/6004624574/job/16300956746?pr=16205

DMRobertson commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/6015777989/job/16318426032

DMRobertson commented 1 year ago

https://github.com/matrix-org/synapse/actions/runs/6016116523/job/16319481679?pr=16175 again

DMRobertson commented 1 year ago

I'm still seeing this today on https://github.com/matrix-org/synapse/actions/runs/6081842673/job/16498376137

erikjohnston commented 1 year ago

Well at least it's flaking at a different point now!

erikjohnston commented 1 year ago

PR for a potential fix incoming

erikjohnston commented 1 year ago

https://github.com/matrix-org/complement/pull/649

clokep commented 11 months ago

This seems to have popped up again once: https://github.com/matrix-org/synapse/actions/runs/6650600407/job/18071014117 will leave closed until it becomes an issue.

DMRobertson commented 10 months ago

Seen in https://github.com/matrix-org/synapse/actions/runs/6953944995/job/18919907563.

DMRobertson commented 10 months ago
❌ TestFederationKeyUploadQuery/Can_query_remote_device_keys_using_POST (30ms)
      federation_upload_keys_test.go:131: MatchResponse key 'device_keys.@user-43:hs1.DAGGZUUSZR.unsigned.device_display_name' missing - http://127.0.0.1:32794/_matrix/client/v3/keys/query => {"device_keys":{"@user-43:hs1":{"DAGGZUUSZR":{"algorithms":["m.olm.v1.curve25519-aes-sha2","m.megolm.v1.aes-sha2"],"device_id":"DAGGZUUSZR","keys":{"curve25519:DAGGZUUSZR":"ANJuaBAjWyjfXKdSg6n1K2s0/sH6rG9h1VesVEUsbD4","ed25519:DAGGZUUSZR":"hYa1XxTgHHGDbJW7ZQSy5dZyfUCDRdl4lKBFhrBtTgY"},"signatures":{"@user-43:hs1":{"ed25519:DAGGZUUSZR":"ZB2UXJKNMN2DfJJRRlTNkQBrxIKw7wom6opqTTxK7xrJ/ChcEQ8JyGenwDnKO2UPMgR+VoCp9JaRspdHQlxXAA"}},"user_id":"@user-43:hs1","unsigned":{}}}},"failures":{},"master_keys":{},"self_signing_keys":{},"user_signing_keys":{}}