matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.82k stars 2.13k forks source link

Send the opentracing span information also to appservices #16227

Closed MTRNord closed 1 year ago

MTRNord commented 1 year ago

This fixes #16226

The intent here is that appservice developers also may be interested to link their traces to the synapse traces. It's treated like the replication traces, since appservices are being run by the same admin. So there is no need to whitelist each appservice domain.

Pull Request Checklist

Signed-off-by: Marcel Radzio support@nordgedanken.dev

MTRNord commented 1 year ago

I am not sure if there is a cleaner way to do this. The underlying HTTP client is shared with other parts of the code, so in my head it made sense to do it just on the appservice code side. If this is not correct, I would need some guidance on a better way to archive a better solution.

MTRNord commented 1 year ago

Test failures are noted and being worked on.

Tests should be fixed