Stop saving `thread_id` in the `data` field of `receipts_graph` - Githubissues

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.82k stars 2.13k forks source link

Stop saving `thread_id` in the `data` field of `receipts_graph` #16297

Closed realtyem closed 1 year ago

realtyem commented 1 year ago

Noticed this while watching the Postgres logs, so went to look deeper and found weird_receipt_graph_artifact

Which doesn't seem right. It's on a JsonDict, so it can be pop()ped instead of just being got().

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[x] Pull request includes a sign off
[x] Code style is correct (run the linters)

Signed-off-by: Jason Little realtyem@gmail.com