search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.82k stars 2.13k forks source link

Fix deleting device inbox when using background worker #16311

Closed erikjohnston closed 1 year ago

erikjohnston commented 1 year ago

Introduced in https://github.com/matrix-org/synapse/pull/16240

The action for the task was only defined on the "master" handler, rather than the base worker one.

erikjohnston commented 1 year ago

How can we prevent this in the future?

Good Q. I wonder if we can somehow leverage the type system here (rather than trying to catch this at runtime and via tests)