matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.82k stars 2.13k forks source link

Ensure emails get mapped to SSO users when the user does not pick a username. #16321

Closed Half-Shot closed 1 year ago

Half-Shot commented 1 year ago

Followup from #16317.

I think the sensible solution here is to default the emails_to_use parameter to the full set returned by the IDP, which will be overwritten if the user goes through the pick flow. This aligns up with the expected flow, as this is already the case if the user doesn't go through the consent flow.

Half-Shot commented 1 year ago

We've not got a use for this now, and with OIDC on the way we're not going to have the resources to work on this. If someone wants to pick it up though, be my guest.