matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.82k stars 2.13k forks source link

Bump ruff from 0.0.286 to 0.0.290 #16342

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps ruff from 0.0.286 to 0.0.290.

Release notes

Sourced from ruff's releases.

v0.0.290

What's Changed

Rules

Settings

Bug Fixes

Preview

What's this section?

New Contributors

Full Changelog: https://github.com/astral-sh/ruff/compare/v0.0.289...v0.0.290

v0.0.289

What's Changed

Bug Fixes

Preview

This release includes a new preview mode which can be used to opt-in to unstable rules and features.

... (truncated)

Changelog

Sourced from ruff's changelog.

Breaking Changes

0.0.288

Remove support for emoji identifiers (#7212)

Previously, Ruff supported the non-standard compliant emoji identifiers e.g. 📦 = 1. We decided to remove this non-standard language extension, and Ruff now reports syntax errors for emoji identifiers in your code, the same as CPython.

Improved GitLab fingerprints (#7203)

GitLab uses fingerprints to identify new, existing, or fixed violations. Previously, Ruff included the violation's position in the fingerprint. Using the location has the downside that changing any code before the violation causes the fingerprint to change, resulting in GitLab reporting one fixed and one new violation even though it is a pre-existing violation.

Ruff now uses a more stable location-agnostic fingerprint to minimize that existing violations incorrectly get marked as fixed and re-reported as new violations.

Expect GitLab to report each pre-existing violation in your project as fixed and a new violation in your Ruff upgrade PR.

0.0.283 / 0.284

The target Python version now defaults to 3.8 instead of 3.10 (#6397)

Previously, when a target Python version was not specified, Ruff would use a default of Python 3.10. However, it is safer to default to an older Python version to avoid assuming the availability of new features. We now default to the oldest supported Python version which is currently Python 3.8.

(We still support Python 3.7 but since it has reached EOL we've decided not to make it the default here.)

Note this change was announced in 0.0.283 but not active until 0.0.284.

0.0.277

.ipynb_checkpoints, .pyenv, .pytest_cache, and .vscode are now excluded by default (#5513)

Ruff maintains a list of default exclusions, which now consists of the following patterns:

  • .bzr
  • .direnv
  • .eggs
  • .git
  • .git-rewrite
  • .hg
  • .ipynb_checkpoints
  • .mypy_cache
  • .nox
  • .pants.d
  • .pyenv
  • .pytest_cache
  • .pytype
  • .ruff_cache
  • .svn
  • .tox
  • .venv

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
DMRobertson commented 1 year ago
synapse/storage/databases/main/event_push_actions.py:1602:24: C416 [*] Unnecessary `list` comprehension (rewrite using `list()`)
synapse/storage/databases/main/events.py:830:20: C416 [*] Unnecessary `list` comprehension (rewrite using `list()`)
DMRobertson commented 1 year ago

Would guess this is https://github.com/astral-sh/ruff/pull/7363

clokep commented 1 year ago

This just needed ruff --fix to be run. 🚀